Decode qualification not correctly evaluated by Sentinel-2 reader with relative path

Not yet, it was more a theoretical thinking, because Adrian said that VFS can’t work with relative paths. An because all readers in s2tbx use the VFS, I was afraid that also the other readers are affected.

Marco, we will make sure that on a local file system all readers can work with relative paths. Except Sentinel-2, have you experienced this issue with other reader(s)?

This means if we try the same with e.g. Spot6, we get the same error and can’t read it?
As long as one works on a local file system relative paths should work.
Python users who use the API, might work with relative paths, too.

The VFS doesn't support relative paths. Therefore in the Sentinel-2 reader plugin no longer supports relative paths.
We will change the method getDecodeQualification to support relative path for local file system.

Calvalus uses SNAP via the API. It tries to find an appropriate reader for some file in a local working directory where the process that uses the API has been started. The file is specified with relative path to the working directory. A test case to verify that the old behaviour is preserved in this case may be (it does not need the actual file, it only ensures that relative paths are handled the same way as absolute paths. Please fix by allowing relative paths, do not fix by simply throwing IllegalArgumentEx in case of relative paths!):

@Test
public void testRelativePaths() {

ProductIOPlugInManager manager = ProductIOPlugInManager.getInstance();
ProductReaderPlugIn readerPlugIn = manager.getReaderPlugIns("SENTINEL-2-MSI-MultiRes-UTM35N").next();
try {
assertEquals(DecodeQualification.INTENDED, readerPlugIn.getDecodeQualification(new File("./S2A_MSIL1C_20160717T085602_N0204_R007_T35TPK_20160717T090142.SAFE/MTD_MSIL1C.xml").getAbsoluteFile()));
} catch (IllegalArgumentException _) {}
try {
assertEquals(DecodeQualification.INTENDED, readerPlugIn.getDecodeQualification(new File("./S2A_MSIL1C_20160717T085602_N0204_R007_T35TPK_20160717T090142.SAFE/MTD_MSIL1C.xml")));
} catch (IllegalArgumentException _) {}
}

Thanks,
Martin